MWall541 / Dragon-Mounts-Legacy

Github Repository for the Dragon Mounts: Legacy Minecraft Mod. Please Report any issues here!
GNU General Public License v3.0
38 stars 36 forks source link

Dragon eggs deleting loot tables? #156

Closed RechercheRaptor closed 1 year ago

RechercheRaptor commented 1 year ago

I'm having the same issue as another user (from the CurseForge page), in that when I have dragon eggs configured to appear as chest loot, they instead make the chest completely empty when they should appear. I didn't run into empty loot chests until I configured this.

AnimalsWritingCode commented 1 year ago

What game and mod versions are you running? Do you have any other mods?

RechercheRaptor commented 1 year ago

Whoops, my bad. I'm on game version 1.19.2, forge 43.2.0, mod 1.19.2-1.1.4a. I had initially been using the mod in a modpack, but I made an isolated launcher with just this mod to test it. With dragon eggs as loot enabled, I went around a creative world teleporting to structures and opening any chests I could find (probably not the most efficient methodology, but it was the only one I could think of). In a little over a dozen chests, two were completely empty (both happened to be in the same woodland mansion- but in my modpack I've found empty chests in Repurposed Structure's dungeons and iirc in some barrels in Structory Towers), which is not something I've encountered before in vanilla. I haven't found any dragon eggs in any chests, so it appears at least that chests that should have eggs are ending up empty somehow.

AnimalsWritingCode commented 1 year ago

I suggest checking out the errors in #99 to see if you are getting the same ones. If so, this is fixed in the current unreleased build. If you have no errors or different ones let me know and I'll try taking a look.

In the meantime, while it may not fix dragon eggs spawning, I believe disabling the eggs from loot tables should at least prevent empty chests from the existing error. https://github.com/Kay9Unit/Dragon-Mounts-Legacy/wiki/Configurations#server

I know that's not the best solution, but it's all I can offer at the moment. I know Kay9 has been working hard to get this release out soon, but has been busy. Hopefully, soon we can get this loot table thing behind us 🤞

EthanWall commented 1 year ago

Can confirm this occurs in mod version 1.1.4a. Using the /loot command to give myself minecraft:chests/simple_dungeon loot occasionally results in an error caused by this mod, and dragon eggs never appear in dungeon chests.

Until this is resolved, I've made a quick CraftTweaker script to add dragon egg loot back into the game. It's a bit ugly, but it should be easy enough to customize, and it mirrors the mod's default loot table modifications.

MWall541 commented 1 year ago

Duplicate of #99