MWall541 / Dragon-Mounts-Legacy

Github Repository for the Dragon Mounts: Legacy Minecraft Mod. Please Report any issues here!
GNU General Public License v3.0
36 stars 34 forks source link

Datapack - Dragons with larger size modifier cannot breed due to big hitbox #203

Open IceaPlayzPC opened 11 months ago

IceaPlayzPC commented 11 months ago

I decided to work on my data pack for fun again and i decided to have one of my breeds a bit larger than the rest... but while i was testing breeding items i came to realize that my poor 1.3x modified scale dragons just cannot reach each other and produce an egg... this is true for the example breed as well which is even larger than my custom breed. I reckon this might be because of the resized hitbox.

Furthermore larger dragons cannot breed with smaller dragons either.

Steps to reproduce:

  1. grab a dragon mounts datapack, perhaps the example one, and change the dragon's size (no need to modify size with the example pack as the example breed is already set to 2)
  2. get a breeding item and breed the dragons (ender pearls for the example breed), can be same breed or with a vanilla breed, doesn't matter
  3. watch as they helplessly try to breed but fail every time no matter how much they try to cram themselves into the same space.

I don't utilize the dragon breeding feature much but thought i may as well report because i'm sure theres people out there who do use it and this may become problematic if the size modifier does get used in vanilla dragonmounts

AnimalsWritingCode commented 11 months ago

So what is happening here is the hardcoded vanilla value makes it so animals have to be within 3 blocks center-to-center before they can breed. It's a pretty easy change to increase that, but there has to be some decision on what to make that value. If it's too large, smaller dragons would breed at range. There could be something dynamic to say 3 or 4 scaled by the size modifier.

I noted this in the AI rework as well. It's slightly more involved to change in the brain system if I remember correctly.

MWall541 commented 5 months ago

This one's quite funny. Yeah, this will be apart of the AI overhaul since it's not exactly urgent.