MXCzkEVM / datadash-wallet

Other
0 stars 1 forks source link

Adding new option to save seed phrase locally in file #203

Closed reasje closed 1 month ago

reasje commented 1 month ago

For Create Wallet we already have three options Email, Wechat and Telegram

In case all these three options are disabled - means users dosent have these in their devices

Then we should enable another option to save file locally in theor device and enable user to create wallet

Note: save file locally will only be enabled when other three options are disabled.

reasje commented 1 month ago

I have not been able to get the right permisisons and save the file downloads folder On IOS the download may not exist so adding that might fix the problem On Android I am getting errors trying to save in Downloads folder

reasje commented 1 month ago

Android save to downloads is working, IOS save to downloads only saves to to app directory downloads not the general one.

reasje commented 1 month ago

IOS doesn't let save files to general Downloads folder IOS seed phase should be saved in app directory For importing from there I need to look for a solution to open that directory

reasje commented 1 month ago

Export and create wallet is done. Import wallet with these options are being tested on each platform url launcher open file File picker open file manager

reasje commented 1 month ago

Only open file manager fit our needs, only url launcher was close but It doesn't work on Android as expected, I have added open file manager as local package because It required higher flutter version and I needed to change It. I am finalizing the import process.

reasje commented 1 month ago

@SanghamitraBhowmick1993 I just merged the feat to pre main qa

  1. In my case IOS simulator is working fine for testing but Android Simulator had problems
  2. We will need to run translations before moving to release
  3. If you have any suggestions for UI/UX improvements, I would be glad to hear
reasje commented 1 month ago

@SanghamitraBhowmick1993 I have enabled test mode and local backup should show up if any option is available After testing I will revert that.

SanghamitraBhowmick1993 commented 1 month ago

For Android, creating a wallet works, but importing does not. The file is saved successfully but fails to import. The same process works on iPhone. I have attached a video demonstrating the issue.

https://github.com/MXCzkEVM/datadash-wallet/assets/93600163/af4e0019-4fe9-4a0b-8ea4-92518a1b5f9e

reasje commented 1 month ago

@SanghamitraBhowmick1993 My Files was the default selected option for me and It always works for me 😅, Plz check this option, If My Files works I will check why Files is not working and report here.

SanghamitraBhowmick1993 commented 1 month ago

yes works with 'My Files' but does not work with 'Files' on android

SanghamitraBhowmick1993 commented 1 month ago

we still have to disable the local file option pre-release

reasje commented 1 month ago

@SanghamitraBhowmick1993 Disabled local seed phrase backup.

SanghamitraBhowmick1993 commented 1 month ago

added Files issue to this ticket https://github.com/orgs/MXCzkEVM/projects/4/views/1?pane=issue&itemId=65352538 Hence closing this one