search

MZachmann / LightLora_MicroPython

Lightweight Interrupt-driven Semtech SX127x Library for MicroPython
MIT License
22 stars 10 forks source link

Update to work with Loboris MicroPython #6

Closed torntrousers closed 5 years ago

torntrousers commented 6 years ago

As per https://github.com/MZachmann/LightLora_MicroPython/issues/5

MZachmann commented 6 years ago

two small requests, if you would... 1) have the flag named self.isLoboris and set it after irqPin is set in init . I don't know the overhead of checking for irq but no sense doing it more than once. So, as in: self.isLoboris = not callable(getattr(self.irqPin, "irq", None)) # Loboris build or upython?

2) in the last changed line use self.irqPin.irq(handler=None, trigger=0) which is strictly cosmetic

Thanks for helping out.

torntrousers commented 5 years ago

Done.

MZachmann commented 5 years ago

you didn't actually make change (2) above but it's not worth fussing with.

torntrousers commented 5 years ago

Oh. i thought it was the trigger=0 missing that you meant but there's a typo of handlefn/None you meant isn't there!