search

MZehren / ADTOF

Additional material for the paper ADTOF: A large dataset of non-synthetic music for automatic drum transcription
Other
48 stars 4 forks source link

Module missing #15

Closed HotzingTone closed 2 years ago

HotzingTone commented 2 years ago

Hello, great thanks for making this dataset! I couldn't find and install the modules automix specified in correctAlignmentConverter.py. Would you please suggest where to download them? Cheers!

MZehren commented 2 years ago

Hello,

It seems that the function calling Automix is a debug function I forgot in the code and is likely deprecated. I would remove the function to correct the issue, or you would have to replace it with your own implementation. But I don't understand how this is an issue since this function is never called.

If you want to install Automix, it is available here: https://github.com/MZehren/Automix. But it is likely outdated compared to the private version I was using.

Does this help?

HotzingTone commented 2 years ago

Hi Mickael,

Thanks for taking the time replying. It does help! And yes you are right, it hasn't been called so far, but I just wanted to make sure all the dependencies are properly installed.

However, I haven't been able to successfully run automaticGrooming.py. The error comes from madmom library saying it couldn't load *.ogg files because ffmpeg is missing, while in fact ffmpeg is installed. It reads:

madmom.io.audio.LoadAudioFileError: "All attempts to load audio file 'data/dataset/audio/audio/Pedro Cap - Calma (Remix ft. Farruko).ogg' failed. Try installing ffmpeg (or avconv on Ubuntu Linux)."

I tried reinstalling ffmpeg and madmom, but it didn't help. I am using MacOS v12.2.1.

Would you have a guess how to solve this? Thank you so much!

MZehren commented 2 years ago

Thank you for your comment.

I did not encounter any issue with FFMPEG personally, but it seems that you are not alone from a quick google search: https://groups.google.com/g/madmom-users/c/xgqHlZuNyIw Can you try what Sebastian suggests in his answer?

The issue does not come from my ADTOF, so it is difficult to help you more than that. Let me know if Sebastian's suggestion does not help you.

HotzingTone commented 2 years ago

Thank you very much Mickael!

I will try the solution later and will let you know if that works!

Much appreciate your help!

HotzingTone commented 2 years ago

Hi Mickael,

After brew reinstall ffmpeg and pip install ffmpeg-python, madmom is now able to find ffmpeg and the problem is solved!

There is still a minor error - the automatic data grooming process sometimes is stopped by failing to read bad MIDI data (out of the range of 0-127).

For that I added a try/except handling in this for loop to skip the bad data, then it all went well!

Thank you very much!

MZehren commented 2 years ago

Good to know, thank you for your input!

I remember having issues with some midi files too. There is already a try/catch here to count the number of occurrences of each type of errors.

I wonder why yours is not caught already. Maybe it doesn't correspond to a "ValueError".

I'm closing this issue now. Mickael