search

Ma27 / rediscala

Non-blocking, Reactive Redis driver for Scala (with Sentinel support)
Apache License 2.0
12 stars 8 forks source link

Test are not stable #16

Closed kardapoltsev closed 5 years ago

kardapoltsev commented 5 years ago

There are a lot of hardcoded timeouts in tests and they are not stable (tests fail on slow environment like travis). Also, what do you think about moving to scalatest instead of specs? I have some free time now for this project (:

Ma27 commented 5 years ago

Yeah, the tests seem to be quite a mess. Way too much output that makes it hard to reason about, rather slow and so on... I tried to clean this up to get the build working on GitLab CI, but I gave up last summer due to time limitations, so any improvements there are welcome! :)

Also, what do you think about moving to scalatest instead of specs

I mostly worked with scalatest (and except for this project nothing with specs), so :+1:

kardapoltsev commented 5 years ago

FYI I've started to work on it.

Ma27 commented 5 years ago

Should be fixed by #17 :tada: