F-Droid inclusion of Micro REPL

emdete commented 10 months ago

I found your app "Micro REPL" and want to add it to the f-droid repo. The app contains some dependencies that collide with the rules given by f-droid so i removed them but did not change anything else.

Please let me know if you are fine with the inclusion.

licaon-kter commented 10 months ago

ref: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13564

Ma7moud3ly commented 10 months ago

Hi @emdete , Yes I agree with the inclusion. Thanks

linsui commented 9 months ago

Could you please tag releases so that we can update the app automatically?

Ma7moud3ly commented 7 months ago

Tags will be added to releases starting from v1.4

licaon-kter commented 7 months ago

Builds fine if I downgrade to Java17: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13564/diffs?commit_id=801ce4632962e80954d965affca30963da9ecd55

...because Debian Stable has Java17 and 19 will be available the future (Testing now)

@Ma7moud3ly are any 18 features used?

licaon-kter commented 7 months ago

Regarding reproducibility ( https://f-droid.org/docs/Inclusion_How-To/#reproducible-builds ) would have been nice, but you currently use Firebase/Crashlytics.

If you'd switch to a FOSS debug lib like ACRA or Bugsnag or Sentry, we could have tried repro.

Ma7moud3ly commented 7 months ago

It is acceptable to either upgrade or downgrade Java version, and the application will build without encountering any issues.
Regarding Firebase services, I am uncertain about finding an alternative, but I can add a new build type that excludes Firebase dependencies from the built apk, however they will still in the source code. Users can then build the app using the following commands: ./gradlew assembleRelease and ./gradlew assembleGmsRelease.

licaon-kter commented 6 months ago

@Ma7moud3ly gradle flavor without Firebase sounds good, now we're doing the clean up before building https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13564/diffs#9f7512cb773fbef9421c237b1f999d2a50e523d7_0_25

ping us when ready to test

Ma7moud3ly commented 6 months ago

@licaon-kter Now we have two build flavours gms with firebase services and default without.

licaon-kter commented 6 months ago

Will test, do note that androidx.navigation:navigation-dynamic-features-fragment depends on androidx.navigation:navigation-dynamic-features-runtime which depends on proprietary com.google.android.play » feature-delivery

licaon-kter commented 6 months ago

@Ma7moud3ly builds fine, any chance to build an APK after merging https://github.com/Ma7moud3ly/micro-repl/pull/11 from default flavor and put it in https://github.com/Ma7moud3ly/micro-repl/releases/tag/v1.4 so we can check for reproducibility?

Ma7moud3ly commented 6 months ago

@licaon-kter done ✅

licaon-kter commented 6 months ago

Ah forgot about java version :(

But that's the last of our worries, looks like a new case of https://gitlab.com/fdroid/fdroiddata/-/issues/3138

difflog: micro9.log

linsui commented 6 months ago

Please update Compose Compiler to 1.5.6. See https://gitlab.com/fdroid/fdroiddata/-/issues/3138

Ma7moud3ly commented 6 months ago

@linsui done ✅

licaon-kter commented 6 months ago

thanks @emdete ands @linsui

Now, if only Fast lane ( https://gitlab.com/-/snippets/1895688 ) folder&files can be setup with description, icon, summary, pics, we are ready to merge

Ma7moud3ly / micro-repl

F-Droid inclusion of Micro REPL #7