search

MaG21 / curry

Currency scraper for the Dominican Republic
MIT License
19 stars 15 forks source link

Add Dockerfile #3

Closed concernedrat closed 7 years ago

MaG21 commented 7 years ago

Before I can accept this PR, first I must fix the tests, they're working fine, however some coverage tests shall be removed due to some internal changes.

Though, I can see that the docker file installs Python dependencies, which I believe aren't necessary.

concernedrat commented 7 years ago

@MaG21 in order to use the command add-apt-repository to add the Ruby-NG PPA, the docker image needs the software-properties-common and python-software-properties which are default debian/ubuntu python based system tools. Using a PPA instead of building from sources enables the image build process to finish faster and reduce the image size. This was a quick solution but due to time constraints I couldn't optimize further, however I encourage future improvements and use a slimmed down OS optimized for containers like Alpine instead of a full fledged debian distro.