static function declared as non static

[GregoireH]

Hi MaJerle,

in tm_stm32_usart.c : I think you missed a static in front of the function definition of TM_USART_INT_InsertToBuffer(...)

https://github.com/MaJerle/stm32fxxx_hal_libraries/blob/master/00-STM32_LIBRARIES/tm_stm32_usart.c#L81

[MaJerle]

Hi,

It is not necessary, or you think is it? ;)

30. okt. 2015 6:03 pop. je oseba "GregoireH" notifications@github.com napisala:

Hi MaJerle,

in tm_stm32_usart.c : I think you missed a static in front of the function definition of TM_USART_INT_InsertToBuffer(...)

https://github.com/MaJerle/stm32fxxx_hal_libraries/blob/master/00-STM32_LIBRARIES/tm_stm32_usart.c#L81

— Reply to this email directly or view it on GitHub https://github.com/MaJerle/stm32fxxx_hal_libraries/issues/1.

[GregoireH]

well depending on your compiler settings, you get an error or warning... :-)

[MaJerle]

Whatt??

30. okt. 2015 6:14 pop. je oseba "GregoireH" notifications@github.com napisala:

well depending on your compiler settings, you get an error or warning... :-)

— Reply to this email directly or view it on GitHub https://github.com/MaJerle/stm32fxxx_hal_libraries/issues/1#issuecomment-152590691 .

[GregoireH]

well, I must confess that :-) I am using a custom Makefile with sublime 3 text editor, using arm-none-eabi compiler I got an error saying :

 ../00-STM32_LIBRARIES/tm_stm32_usart.c:256:13: error: static declaration of 'TM_USART_INT_InsertToBuffer' follows non-static declaration
 static void TM_USART_INT_InsertToBuffer(TM_BUFFER_t* u, uint8_t c) {
             ^
../00-STM32_LIBRARIES/tm_stm32_usart.c:81:6: note: previous declaration of 'TM_USART_INT_InsertToBuffer' was here
 void TM_USART_INT_InsertToBuffer(TM_BUFFER_t* u, uint8_t c);
      ^
Makefile:122: recipe for target `../00-STM32_LIBRARIES/tm_stm32_usart.o' failed

[MaJerle]

Aaa this. Ok yeah! Will fix it.

30. okt. 2015 6:21 pop. je oseba "GregoireH" notifications@github.com napisala:

well, I must confess that :-) I am using a custom Makefile with sublime 3 text editor, using arm-none-eabi compiler I got an error saying :

../00-STM32_LIBRARIES/tm_stm32_usart.c:256:13: error: static declaration of 'TM_USART_INT_InsertToBuffer' follows non-static declaration static void TM_USART_INT_InsertToBuffer(TM_BUFFER_t* u, uint8_t c) { ^ ../00-STM32_LIBRARIES/tm_stm32_usart.c:81:6: note: previous declaration of 'TM_USART_INT_InsertToBuffer' was here void TM_USART_INT_InsertToBuffer(TM_BUFFER_t* u, uint8_t c); ^ Makefile:122: recipe for target `../00-STM32_LIBRARIES/tm_stm32_usart.o' failed

— Reply to this email directly or view it on GitHub https://github.com/MaJerle/stm32fxxx_hal_libraries/issues/1#issuecomment-152592642 .

[GregoireH]

Great,

I ll email you for a personal question then. Cheers