MaKiPL / OpenVIII-monogame

Open source Final Fantasy VIII engine implementation in C# working on Windows and Linux (Android and iOS planned too!) [Monogame]
MIT License
645 stars 59 forks source link

An invalid descriptor of the "zzz" entry #129

Closed Albeoris closed 5 years ago

Albeoris commented 5 years ago

There is a wrong file entry description:

        public struct FileData
        {
            public uint FilenameLength;
            private byte[] filenameascii;
            public uint Offset;
            public uint UnkFlag;//Boolean
            public uint Size;
        }

Change a type of the Offset field from UInt32 to UInt64. There is no UnkFlag. It's a part of offset to support large archives (> 4 Gb).

Albeoris commented 5 years ago

Also, I'm almost sure that the encoding is UTF8.

Sebanisu commented 5 years ago

Yep I saw that on myst6re's qt-zzz and thought it was a possibility because that value was always zero. I just need to change it on here. I wonder if i can link to my other project in here instead of having two copies of files.

On Wed, Sep 4, 2019 at 5:11 PM Albeoris notifications@github.com wrote:

There is a wrong file entry description:

    public struct FileData
    {
        public uint FilenameLength;
        private byte[] filenameascii;
        public uint Offset;
        public uint UnkFlag;//Boolean
        public uint Size;
    }

Change a type of the Offset field from UInt32 to UInt64. There is no UnkFlag. It's a part of offset to support large archives (> 4 Gb).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MaKiPL/OpenVIII/issues/129?email_source=notifications&email_token=AAH45APPCV7LICI4BBHMUJTQIAP63A5CNFSM4ITWRZCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJLVFBQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH45AJWL37Q6BRPFXRGJDDQIAP63ANCNFSM4ITWRZCA .

-- ---Robert Russell Unemployed Programmer Google Profile http://www.google.com/profiles/peeceseven

Sebanisu commented 5 years ago

Also, I'm almost sure that the encoding is UTF8.

It's possible, I didn't think about that. I knew it had to be byte length. I don't think any of the files in the zzz have special characters though. and anything under like 127 should be the same in ascii and utf8. If I remember correctly.

Sebanisu commented 5 years ago

https://github.com/MaKiPL/OpenVIII/commit/608682b7ec170f28bbec3765abdd3b824ce4d579 descripter fixed in commit