MaKiPL / OpenVIII-monogame

Open source Final Fantasy VIII engine implementation in C# working on Windows and Linux (Android and iOS planned too!) [Monogame]
MIT License
630 stars 58 forks source link

Enemy class formatting #163

Closed FlameHorizon closed 4 years ago

FlameHorizon commented 4 years ago

Hey. I've started working on improving code in the Enemy.cs class. Because I haven't found any coding conventions which this projects suppose to follow, I applied mine which I closely follows (but not exactly) Microsoft’s convention.

Idea is that it's better have any convention and follow it rather than making mess in the code.

PS. I still see few places where code can be improve.

Sebanisu commented 4 years ago

I have done this on my fork. I have been dragging my feet. I should probably commit to master. though I haven't tested it thoroughly.

FlameHorizon commented 4 years ago

Thanks for the info. I looked at your fork and it looks promising. What do you think, should I wait for your changes to be applied into master?

If you find any changes of mine interesting, feel free to include them :)

I guess it makes this PR irrelevant.

Sebanisu commented 4 years ago

I will try to get it merged by Monday. I work weekends.

FlameHorizon commented 4 years ago

Cool @Sebanisu. Cheers!