search

MaKiPL / OpenVIII-monogame

Open source Final Fantasy VIII engine implementation in C# working on Windows and Linux (Android and iOS planned too!) [Monogame]
MIT License
630 stars 58 forks source link

Laguna's team member names. #164

Open Sebanisu opened 4 years ago

Sebanisu commented 4 years ago

On save menu and battle menu Laguna's team member's names isn't populating.

Sebanisu commented 4 years ago

Should be an easy fix. Just querying the data wrong. They're odd because they use someone else's character data.

Sebanisu commented 4 years ago

One issue is TeamLaguna isn't set unless the game is loaded. So the load game menu will display the wrong value CharacterData isn't connected to the savedata. So values could be displayed wrong. I've corrected the name by not using the built in property. Though stats could be wrong if loading the wrong id from kernel.

Sebanisu commented 4 years ago

For load screen i'm bypassing the teamlaguna checks and going directly to the data. So level, character name and gold now should show correct values.

Sebanisu commented 4 years ago

most of this has been fixed. I restricted access to the character's dictionary. to prevent bypassing the team laguna checks and fixed partyPos so it isn't set to -1 when it can't find laguna in the party data list.

one bug remains that i saw which is when i load a save the data in the menu's isn't refreshed so names don't change etc.