search

MaKiPL / OpenVIII-monogame

Open source Final Fantasy VIII engine implementation in C# working on Windows and Linux (Android and iOS planned too!) [Monogame]
MIT License
645 stars 59 forks source link

hotfix. FFVIII wouldn't start correctly and experience exceptions. ho… #173

Closed taiBsu closed 4 years ago

taiBsu commented 4 years ago

…wever it starts now but has various display issues and starting a new game doesn't work.

Sebanisu commented 4 years ago

If you need a try catch block Maybe something else is wrong. I kinda like to avoid them as they can mask coding errors. Where I would like the exception to pop up as say issue here.

On Sun, Jun 28, 2020, 2:04 PM taiBsu notifications@github.com wrote:

…wever it starts now but has various display issues and starting a new game doesn't work.

You can view, comment on, or merge this pull request online at:

https://github.com/MaKiPL/OpenVIII-monogame/pull/173 Commit Summary

  • hotfix. FFVIII wouldn't start correctly and experience exceptions. however it starts now but has various display issues and starting a new game doesn't work.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MaKiPL/OpenVIII-monogame/pull/173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH45AM6CT6NP6JFD6XBRYTRY6A4DANCNFSM4OKULGFA .

taiBsu commented 4 years ago

I just realized that the code I wanted to push doesn't even exist in the latest version anymore so I guess that pull request can be left over.