search

MaKiPL / OpenVIII-monogame

Open source Final Fantasy VIII engine implementation in C# working on Windows and Linux (Android and iOS planned too!) [Monogame]
MIT License
630 stars 58 forks source link

Possible translation fix in FF8-Remastered. #176

Open RJesusTVD opened 3 years ago

RJesusTVD commented 3 years ago

Hello. First time reporting a issue here. Hope it can help.

This line is causing the selection of german language.

https://github.com/MaKiPL/OpenVIII-monogame/blob/c0260c953c0350d500b0778d396e61a7403fdd86/Core/Archive/ArchiveMap.cs#L97

Since its using the first finding, it will always select the "lang-de" and it will not look in any other language folder. Maybe use the language indicator that is defined in Memory class and check against the localInput path.

If it can find the file in the root of the data folder, go on with it. Otherwise it should look for the file in the language related folders.

Sebanisu commented 3 years ago

I think that's mainly an issue on remaster. The other versions only have one language installed at a time.