MaMpf-HD / mampf

MaMpf (Mathematical Media Platform) — an E-Learning platform for mathematics featuring a media player & editor. Developed & deployed at Heidelberg University.
https://mampf.mathi.uni-heidelberg.de/
MIT License
28 stars 10 forks source link

Module selection & page offset on mobile devices #25

Open christian-heusel opened 4 years ago

christian-heusel commented 4 years ago

current state :exclamation:

Screenshot_20191209-023021_Samsung Internet

expected behavior :100:

:snake: :man_firefighter: :1st_place_medal:

fosterfarrell9 commented 4 years ago

I will take care of this after the holidays.

christian-heusel commented 4 years ago

Whilst playing around with boostrap for another project I noticed that the strange page offset is caused by the row class here: https://github.com/fosterfarrell9/mampf/blob/28c054d9375450e6b47bcd46e4b857284088d297/app/views/shared/_footer.html.erb#L2 https://github.com/fosterfarrell9/mampf/blob/28c054d9375450e6b47bcd46e4b857284088d297/app/views/shared/_footer.html.erb#L35 https://github.com/fosterfarrell9/mampf/blob/28c054d9375450e6b47bcd46e4b857284088d297/app/views/shared/_footer.html.erb#L54

Whilst removing it resolves the issue ofc the content formatting is lost, but knowing what causes the bug is atleast something.

Merry Christmas :christmas_tree: :gift:

christian-heusel commented 4 years ago

Why did this issue get closed? As far as I know one of the two misbehaviours remains unsolved @henrixapp ...?

henrixapp commented 4 years ago

Sorry. We just saw your one commit and thought this addresses the whole issue.

christian-heusel commented 4 years ago

Its better now but some of this stuff should collapse into a menu and the search field and Course name should be on different lines image