search

MaNeRz / PBE_NewAssetsDownloader

Be always up-to-date with what's coming into League of Legends
GNU General Public License v3.0
2 stars 0 forks source link

CDTB is not always up to date #1

Closed Neinndall closed 2 years ago

Neinndall commented 2 years ago

It seems to download a lot of old assets and not the recent ones from the current update. It would be very interesting if the program classify them by days. I have checked in today's update on December 9 and it seems that it has given 2 new assets that I have checked:

I have run it again and it seems that the program has added it to the ... 3000 assets, this is too messy. I don't know if I will be able to add my updated hashes that I do it manually, or you should take a look. It would be interesting that every time the program is executed it gives you the output of the new ones, not the old ones! I do not know if you will change its operation or apply a new feature!

Thanks!

MaNeRz commented 2 years ago

Hey, Thank you for your feedback. The first time you open the program the Assets.txt file is generated by making a request to the latest files extracted from the live server and the NewAssets.txt file, insted, is generated by making a request to the latest files extracted from PBE. Then the program will replace the NewAssets.txt to Assets.txt. From the second time you open the program or if the Assets.txt already exist the program will make request only to latest PBE files extracted. For the 3000 assets we have to thank Rito for the new challenges system. I'm currently working on a new way to save the assets based on days. 😄

Neinndall commented 2 years ago

If I have not misunderstood, for example the PBE for tomorrow, as soon as the update is complete, I will run this program and will I get the new assets?

Edit: Today the 10th, I ran a guess_hash from CDTB, what did you find is not suggested assets? I will attach some images!

guess_hashes_from_today pbe_assets

On the other hand, it is amazing if the program separates by days when the user just executes when the PBE patch is out!

Thanks! :3

MaNeRz commented 2 years ago

Hey, sorry for the late reply, I don't know how much time CDTB needs to update. I tried the CDTB and took a lot of time to downloads all the files and create the tree pattern so i think the guess_hash is faster if you already have the .wad and .bin files. The thing is i don't know how the guess_hash works and for now this program supports only the requests to the Raw files from cdragon site. So if the site is not updated the program will download nothing. 😞 XD I made it just to improve how my code looks like and you are giving me some cool ideas to make it better. Have to really thank you!!! :3

Neinndall commented 2 years ago

Do not worry! What I do is when a patch comes out, I use a script to "suggest" the new assets, files (hashes from the game and lcu) I could give you or share more information, to try to give you ideas of how you could include great improvements! It would be a pleasure to share with you how hash works! If you have discord, you can contact me or we can talk over there Th3Nigh7mare#9843