Rework autotrade algorithm

[macdjord]

• New version will now always trade with Leviathans if possible; old version only traded with them if gold was near cap
• New version will only trade with Zebras and Dragons is gold is within 26 ticks' production of cap; old version would trade if within 200 ticks
• New version will trade with Zebras and Dragons if the critical resource (titanium and uranium, respectively) is more than 25 ticks' production below cap; old version would trade with Zebras if titanium was below 90% and with Dragons unconditionally
• New version estimates how many trades are necessary to fill the critical resource and limit itself to executing that many trades with Zebras and Dragons (with the Leviathans, it always executes the maximum possible number of trades); old version would always trade the maximum, even if that cause massive waste
• New version, when trading with Zebras, calculates how much iron the trade could potentially return, and crafts iron into plates as necessary to ensure there's enough room in the iron stockpile to fit it all; old version did not do this, causing it to frequently waste the iron
• New version can trade with multiple partners in a single cycle; old version would only ever trade with one partner per call

[macdjord]

• Resolves Issue #9
• Resolves most of the suggestions in Issue #3 (everything except adding a button to control which trades are executed and adding support for trading with the Spiders)

[macdjord]

Additional changes:

• Added support for trading with the Spiders for coal (as requested in Issue #3)
• Changed conditions under which non-Leviathan trades are performed: cap is now 5 ticks below limit instead of 25, but it won't trade at all if there isn't enough room in the stockpile for at least one full trade (unless it's titanium and the stockpile is below 90% full, in which case it will always perform at least one trade), and trade with the Dragons won't happen if your titanium stockpile is filled beyond its normal limit
• Added another function to trade with the Sharks for catnip if starvation is imminent (which largely obviates Issue #4)

[macdjord]

Additional changes:

• Emergency food trading now triggers at 5 ticks' consumption or 2% of max catnip, whichever is higher, to avoid an edge case that could occur if you actually hit 0 catnip
• Added major new feature, maximized trading, for uranium and coal, which, instead of trading just enough to fill your stockpile, determines the maximum amount you can currently trade for, and converts your existing uranium or coal (into thorium and steel respectively) in order to make room
  • I added this because I often found myself sitting there, repeatedly hitting the 'Craft all thorium' or 'Craft all steel' buttons, then waiting for autoTrade to fill my stockpiles back up before doing it again.
  • The maximized trading feature is controlled by a pair of checkboxes on the script main menu. In irder to make room for them, I moved the entire menu up 200 pixels; while I was at it, I also moved autoBuild's building select window up 100 pixels, making all the buildings visible (fixes Issue #1)

[eliliam]

It's been a while, but this would be so welcome, @MaPaul1977 what do we need to do to get this merged?

[macdjord]

Wow, this is a blast from the past.

FYI, I think I've spotted a bug on https://github.com/macdjord/KittensGame/blob/TradeImprovement/ScriptKitties.js#L849 - it should be looking at the minimum of iron and coal, not iron and iron again. But it's been too long to be sure that wasn't deliberate for some obscure reason, and I no longer play KittensGame so I can't test it.

[macdjord]

@eliliam Note that I have another PR, #16, which includes all the changes from this one plus some more.

[MaPaul1977]

Woah. I forgot I wrote this. Look like there are no conflicts. Consider it merged.

[MaPaul1977]

Let me know when PR 16 is up and I'll merge it too. Only 15 was available.