search

MaRDI4NFDI / portal-compose

docker-composer repo for mardi
https://portal.mardi4nfdi.de
GNU General Public License v3.0
3 stars 1 forks source link

Remove prefixes.conf #537

Closed eloiferrer closed 3 weeks ago

eloiferrer commented 3 weeks ago

MaRDI Pull Request

With the current configuration, the prefixes.conf for the production server are applied by default when one runs portal-compose locally.

This is problematic because volumes cannot be deleted in docker-compose.override.yml once they have been declared in docker-compose.yml as in https://github.com/MaRDI4NFDI/portal-compose/blob/8c7d284ba87f2ccc1f0f34da829bb083b52808b0/docker-compose.yml#L213

Instead of declaring an additional prefixes.conf file for development, I think it is better to move back prefixes.conf into the configuration for the production server in srv-mardi02.

Changes:

Instructions for PR review:

Checklist for this PR:

eloiferrer commented 3 weeks ago

See https://github.com/MaRDI4NFDI/portal-compose/pull/538/files