MaRDI4NFDI / python-zbMathRest2Oai

Read data from the zbMATH Open API https://api.zbmath.org/docs and feed it to the OAI-PMH server https://oai.portal.mardi4nfdi.de/oai/
GNU General Public License v3.0
4 stars 0 forks source link

Remove code and replace in test data #35

Closed physikerwelt closed 9 months ago

physikerwelt commented 9 months ago

This replacement

https://github.com/MaRDI4NFDI/python-zbMathRest2Oai/blob/ebe5fc3e82f83dd550fc6ac755d2c1bb5a0506f7/test/test_software_metadata.py#L26C1-L34C33

can be avoided, if one replaces the reference data.

Mazztok45 commented 9 months ago

I updated https://github.com/MaRDI4NFDI/python-zbMathRest2Oai/blob/main/src/zbmath_rest2oai/write_local_test.py

and https://github.com/MaRDI4NFDI/python-zbMathRest2Oai/blob/main/test/test_software_metadata.py

Does it look better now?

physikerwelt commented 9 months ago

Ok, I just wanted you to write 0 to the reference file, but that is also ok. Now the build fails.