search

MaRDI4NFDI / python-zbMathRest2Oai

Read data from the zbMATH Open API https://api.zbmath.org/docs and feed it to the OAI-PMH server https://oai.portal.mardi4nfdi.de/oai/
GNU General Public License v3.0
4 stars 0 forks source link

Save software and article with prefix #36

Closed physikerwelt closed 8 months ago

physikerwelt commented 9 months ago

Use

oai:zbmath.org:2615555

for articles and

oai:swmath.org:2

for software. The last number is the DE number or the swMATH id respectively.

Mazztok45 commented 8 months ago

I believe my last commit, https://github.com/MaRDI4NFDI/python-zbMathRest2Oai/commit/518cd7ca7ef94387071872ebaccfbad3f7ec6018, fixes this problem by adding the prefix to the identifier.

Do you see any other challenges to close this issue?

physikerwelt commented 8 months ago

It seems like a hack. I suggest using a parameter better. I mean if the url would contain software we had false results, or when the API implementation changes and software is not part of the URL it would also produce false results.

Mazztok45 commented 8 months ago

You are right. I will implement adequate parameters.

Mazztok45 commented 8 months ago

I implemented https://github.com/MaRDI4NFDI/python-zbMathRest2Oai/commit/4e89e3b98cf009773cb007447d16dda7c0641db7 to add the prefix as a parameter, as you suggested. Do you see other necessary improvements?