search

MaRDI4NFDI / python-zbMathRest2Oai

Read data from the zbMATH Open API https://api.zbmath.org/docs and feed it to the OAI-PMH server https://oai.portal.mardi4nfdi.de/oai/
GNU General Public License v3.0
4 stars 0 forks source link

devoloping creators , title , description and publicationYear in the xslt for software #84

Closed Shirazos7 closed 1 month ago

Shirazos7 commented 4 months ago

Issue description: we have a new plain.xml which includes some changes of our metadata therefore new devolopoment needed to be done in xslt and reference of software metadata

i created a new branch for this work i needed to delete all of old work and start a new constrction for our xslt , which leads also to delete the old reference.xml and build from scratch better shape matches with Datacite.

TODOS: identifier , creators , titels , description and publicationYear are going to be excuted in this issue to be solved and devoloped accordingly

Shirazos7 commented 4 months ago

this commits should fix the issue

6ef021c 8745ead

Shirazos7 commented 4 months ago

@Mazztok45 @physikerwelt
i will look forward for your feedback. I hope this matches the demand to reshape the creators

physikerwelt commented 4 months ago

Looks good, but this is not a pull request. Have you watched the 7min video I shared with you. You can create the pull request from the GitHub web user interface in just a few minutes without any computer skills.

Shirazos7 commented 4 months ago

i made a pull request and it was successfully merged with no conflicts

physikerwelt commented 4 months ago

Almost good. You should have looked at the checks. They told you that you should have removed an unnecessary import. https://app.deepsource.com/gh/MaRDI4NFDI/python-zbMathRest2Oai/run/d9430bc7-3f4c-41c0-9d16-0472cb15a7b7/python/PY-W2000?listindex=0

Shirazos7 commented 4 months ago

yes i agree with you , i made a new pull request and assigned maxence to approve it with necesssary changes in the python code and also new adjustments in xslt .

physikerwelt commented 4 months ago

Perfect. As a rule of thumb, you should assign either Maxence or me. If you assign me, I will review it quickly, but I need to understand the context. So you would add some more text explaining what the goal is and what the intended effect is.

Shirazos7 commented 4 months ago

okay , in the next pull request i will assign you as well and write and explain the effects of the work that i want to merge