MaYuehan / pe

0 stars 0 forks source link

The constrains of fields are not included in UG #4

Open MaYuehan opened 3 months ago

MaYuehan commented 3 months ago

As shown in the exception messages of add command, every fields have they own constrains, however, in the new user tutorial or the feature section, the constrains of some field are not stated. For exampple, the email field in add command: the exception message: Screenshot 2024-04-19 at 4.37.57 PM.png

the new user tutorial: Screenshot 2024-04-19 at 4.25.13 PM.png

the feature sections:

Screenshot 2024-04-19 at 5.32.48 PM.png

the constrains of email field is also not included in the edit command.

Screenshot 2024-04-19 at 5.40.20 PM.png

nus-se-bot commented 2 months ago

Team's Response

Most email addresses follow a common format, and that format is acceptable within the bounds of our input validation (and also stated in our error messages).

Hence, we did not see a need to explicitly mention this constraint as it would already fit what most end users expect.

However, for the sake of consistency, we accept this as a very low severity, minor documentation bug.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: No constrains stated in the UG might not affected normal operations of produce but it can cause inconvience in rare situations such as the users is not familiar with email address and forget the format of email. This fits the description of severity.low

Screenshot 2024-04-18 at 5.40.25 PM.png