search

Maagan-Michael / invitease

A self contained invitation management system for gatekeeping.
GNU General Public License v3.0
8 stars 1 forks source link

api enhancements #64

Closed KamiTzayig closed 2 years ago

KamiTzayig commented 2 years ago

api update, includes all api needed for inviter, guard and added server_defaults on models.py

inbarbarkai commented 2 years ago

Great coding, now just fix all the pep8 violations and we're done

yarons commented 2 years ago

@KamiTzayig @inbarbarkai It can be done as a continuous effort: https://pypi.org/project/pep8/

inbarbarkai commented 2 years ago

@yarons from my experience, code written is not touched unless a fix needs to be introduced. And even then, only the necessary parts. Coding conventions are important for code readability. I don't know a repo that will allow you to add work that doesn't follow it.

I want to say again that @KamiTzayig did really great work here. He can take a little more time to for fixing those minor issues.

yarons commented 2 years ago

@inbarbarkai It's not for current code, it's for future code, think of it more like CI as part of the code, I can also create a GitHub action to check that while creating a PR.

inbarbarkai commented 2 years ago

Fine