search

Maakaf / maakaf-website

The official website of 'Maakaf' community
https://maakaf-website.vercel.app
MIT License
20 stars 54 forks source link

feature: Add workflows (Devops people!) #29

Open RoyTennenbaum opened 1 year ago

RoyTennenbaum commented 1 year ago

Description

Create a workflow that does this: Whenever someone submits a PR and is waiting for review, transfer the issue/PR from 'In Progress' column to 'Awaiting Review' column.

Screenshots

image

Additional information

No response

ronnahmias commented 1 year ago

Hi, please assign me to this issue :) @RoyTennenbaum

ronnahmias commented 1 year ago

And What about other steps? Like when someone opens and issue, what if this issue needs a fixes after your review?

RoyTennenbaum commented 1 year ago

Hi Ron!

Several workflows exist on GitHub by default, accessible on this repo's project. Notice the five columns and imagine the workflows that should exist, you are welcome to add as many as you want, I'll await the results!

And I'll change the title :)

ronnahmias commented 1 year ago

Thanks! I will start working on this soon as possible. You can mentioned which steps you are doing now manually? I have see that not all the issues is associate with the project. Should all issues will assign to TODO column project? Also, can we change the name of the project? image @RoyTennenbaum

RoyTennenbaum commented 1 year ago

go to the project -> click on the top right corner -> should see a dropdown with a link to "workflows". Browse those, I activated most of them

ronnahmias commented 1 year ago

image I don't find. Maybe I don't have permissions

ronnahmias commented 1 year ago

Hi, I have done some research and didn't find a solution until now. The problem is that in the project there is now only issues and not pr, and the status of what you want is in the pr. Issue can have multiple pr on it as mentioned and there is no relation of one-to-one. If on the project we will add only pr's we can do that automation. @RoyTennenbaum

rotembarsela commented 1 year ago

I think that adding prettier format and linting check every PR will be helpful as well

ronnahmias commented 1 year ago

I think that this can be in other issue. you can open other one? @rotembarsela

rotembarsela commented 1 year ago

I think that this can be in other issue. you can open other one? @rotembarsela

36

ronnahmias commented 1 year ago

Hi, I have look over all the workflow automations and set what I think is good. I have opened an issue to demonstrate the automation and it looks good, you can check here - https://github.com/Maakaf/maakaf-website/issues/39

The missing that I have seen for now is that when awaiting for review on PR is coming the issue is not moving to column. I think there is no option also with github actions because on the projects for now there is only issues and an issue can have many PR's.

@RoyTennenbaum what do you think? @rotembarsela maybe you have an opinion, it would be great

rotembarsela commented 1 year ago

Hi, I have look over all the workflow automations and set what I think is good. I have opened an issue to demonstrate the automation and it looks good, you can check here - #39

The missing that I have seen for now is that when awaiting for review on PR is coming the issue is not moving to column. I think there is no option also with github actions because on the projects for now there is only issues and an issue can have many PR's.

@RoyTennenbaum what do you think? @rotembarsela maybe you have an opinion, it would be great

Looking good, maybe there is an option to allow contributer to link an issue to PR via the "development" tab on the PR, when Roy assign someone to the Issue, the person will get access to the development tab and link a new PR to it, and it will automatically move it on the GitHub Projects, is it doable?

RoyTennenbaum commented 1 year ago

Do you guys think perhaps it is related to the access to projects? I have limited it to read only access on project page, maybe letting everyone access will prove to work? @ronnahmias @rotembarsela

ronnahmias commented 1 year ago

We have only the problem with awaiting review. This column is necessary? You are getting emails when someone waiting for your review no? @RoyTennenbaum

RoyTennenbaum commented 1 year ago

@ronnahmias I reworked the project columns and got rid of the "awaiting review" column. Now it will only be neccesary for people to link their PR to the Issue for me to notice and review it :)

please contact me privately or on a discord meeting for further updates

RoyTennenbaum commented 1 year ago

@ronnahmias I believe the only things missing currently is these workflows:

  1. When assigning someone the issue will automatically move from 'todo' to 'in progress'.
  2. When closing an issue for being irrelevant (not merged) it will automatically move to the archive.

Please add these if possible :)

ronnahmias commented 12 months ago

Hi, I will not be available in the near future, so if anyone is interested in taking the issue. Sorry for that @RoyTennenbaum

RoyTennenbaum commented 12 months ago

It's alright, thanks for letting us know @ronnahmias Anyone up for the task? It has changed and is not too difficult

Darkmift commented 3 months ago

Added playwright to workflow validation/test