Closed jinboson closed 2 years ago
Thanks for the contribution, I have one question though: what is the purpose of this:
#if defined(__loongarch__)
GoPageRecord();
#endif
This does not seem to have anything to do with the CPU architecture.
Thanks for the contribution, I have one question though: what is the purpose of this:
#if defined(__loongarch__) GoPageRecord(); #endif
This does not seem to have anything to do with the CPU architecture.
Thanks for your reply!
You are right. The second patch has nothing to do with the CPU architechure. It's just a minor improvement of simplifying the way of using SSR on the CPU architecture. Because, for most end-users , they maybe don't know the true meanings of the parameters in InputPage and OutputPage, and in most cases, the default configurations work very well, so just skip directly to PageRecord instead of clicking 'continue button' every time as SSR starts. BTW, do I need to create a new pullrequest for the second patch ?
Thanks, Jin Bo.
I think it would be better to add a command-line option that defines the starting page (welcome, input, output or record) so it doesn't have to be baked into the software. It certainly doesn't make sense to change the starting page depending on the CPU architecture. Something like:
--start-page=PAGE Start the application at the defined PAGE, which should be welcome, input, output or record
Then the distribution can set the default behavior if they want using options in the simplescreenrecorder.desktop
file.
ok, I will try.
Hi, Maarten:
I have updated the second patch according to your advice.
Thanks, Jin Bo.
Hi, Maarten:
Is it possible to merge the PR into master ?
Hi, MaartenBaert:
Thanks for your outstanding work! We add loongarch support for SSR and make a minor modification on loongarch. We hope to merge this into master branch.
Thanks, Jin Bo.