search

MaartenGr / PolyFuzz

Fuzzy string matching, grouping, and evaluation.
https://maartengr.github.io/PolyFuzz/
MIT License
733 stars 67 forks source link

N best matches for sparse matrix #13

Closed tap222 closed 3 years ago

tap222 commented 3 years ago

I have done changes to find N best matches from sparse matrix method and introduced a new parameter nbest.

tap222 commented 3 years ago

Hi,

I have added another parameter called nbest and it is failing due to it.

MaartenGr commented 3 years ago

Thanks for the PR. Although creating the top N matches is a nice feature, it also has consequences for custom distance models. These models are not expected to return multiple best matches and require a significant overhaul in order to work after the changes. Also, every check should succeed without exceptions.

I will keep the changes in mind and check in the upcoming weeks on how to best integrate them!