search

Maarti / JenkinsDocExtension

Extension for VS Code providing Jenkins docs
GNU General Public License v3.0
12 stars 2 forks source link

Fix Go-to to work with function definitions #31

Closed benmdavidson closed 3 years ago

benmdavidson commented 3 years ago

Although not extensively, I did test this on my own code and it works. If the function call has no prefix it assumes it's in the current file and finds the definition. I refactored the regex to accurately capture. The regex was not capturing my function declaration so I truncated the regex and it worked for me

benmdavidson commented 3 years ago

See issue #29 . Turns out the regex was the problem and not repeated use

Maarti commented 3 years ago

Thank you for your feedback, I will not merge this PR because it removes a piece of the declaration pattern of a method and search all files without distinction. But instead, I modified the regex to work in multi-line (as discussed in #28) in PR #32 and published version 1.6.0 of the extension.