Maassoft / ColorControl

Easily change NVIDIA display settings and/or control LG TV's
GNU General Public License v3.0
829 stars 39 forks source link

Clicking on the border generates ColorControl.Program error (v971) #287

Closed Amoeba00 closed 7 months ago

Amoeba00 commented 7 months ago

Just upgraded to v971 from 970 Also, noticed the scaling is a bit off and the words are no longer auto-adjusting (with/without GDI scaling enabled)

Discovered that when I click on the border - an error is generated. Basically, if you click on any part that's not the tab - the error is generated.

image

Everything else in log is green:

image

Text:

Exception in thread: Object reference not set to an instance of an object.
   at ColorControl.MainForm.MainForm_Click(Object sender, EventArgs e) in .\MainForm.cs:line 1294
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at InvokeStub_SendOrPostCallback.Invoke(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
   at ColorControl.Program.GlobalThreadExceptionHandler(Object sender, ThreadExceptionEventArgs e) in .\Program.cs:line 321
   at ColorControl.Program.MainAsync(String[] args) in .\Program.cs:line 162
   at ColorControl.Program.Main(String[] args) in .\Program.cs:line 51

Screenshot: image

Maassoft commented 7 months ago

The error is caused by test code for the Nvidia controller that I forgot to remove. It will crash if you don't have a Nvidia GPU. I'm not sure what happened with the scaling, nothing is changed between 9.7.0.0 and 9.7.1.0 that could interfere with the scaling of the UI. Maybe caused by a Windows update or something else? I don't use scaling myself so those issues are easily missed then. I will increase the widths of these group boxes, there's enough room anyway.

Amoeba00 commented 7 months ago

Ahh - Funny - when I started using your app I was on Team Green (2070S), but then upgraded to Team Red (7900xtx). Also, I only noticed it because of those errors - it may have been there for a while and I just never noticed it on recent versions or maybe it only happens on the Radeon cards.

Amoeba00 commented 7 months ago

Confirmed fixed with v9.7.2 - thanks!