MaastrichtU-CDS / DataFAIRifier

A system that supports the creation and validation of mappings and the creation of RDF data from relational data.
Apache License 2.0
7 stars 5 forks source link

ComparisonEngine: plotting fails on "no numeric value" #26

Open MartineDeVos opened 6 years ago

MartineDeVos commented 6 years ago

Visualization of database output is currently based on plotting the values, but the database columns often contain non-numeric values. Therefore we would rather visualize the count of variables

bpmweel commented 6 years ago

It seems this is fixed with 1648a71481b581e5e1cb3c2b666fe7d9cd55f87b

jvsoest commented 6 years ago

Yes, that was my attempt. However it might now fail for numerical/continuous variables. Not sure if we can check the column type in pandas, and then make some switch for numerical/categorical variables.

Gr. Johan (Mobile)


From: Berend Weel notifications@github.com Sent: Thursday, May 17, 2018 11:03:09 AM To: maastroclinic/DataFAIRifier Cc: Subscribed Subject: Re: [maastroclinic/DataFAIRifier] ComparisonEngine: plotting fails on "no numeric value" (#26)

It seems this is fixed with 1648a71https://github.com/maastroclinic/DataFAIRifier/commit/1648a71481b581e5e1cb3c2b666fe7d9cd55f87b

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/maastroclinic/DataFAIRifier/issues/26#issuecomment-389797349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXOc-xLWezqZEPzNSFM3rei8KQuBYbkks5tzTzNgaJpZM4TyjhO.