search

Maato / thunar-dropbox

Plugin for thunar that adds context-menu items for dropbox.
GNU General Public License v3.0
32 stars 5 forks source link

Thunar crash when clicking on invalid encoding Item #5

Closed DanielAW closed 9 years ago

DanielAW commented 9 years ago

Thunar crashes when I click on an Item in the file list which got an invalid encoding. After uninstalling thunar-dropbox, the crash didn't happen again.

The last thing Thunar reports before the crash is:

(thunar:17107): GLib-WARNING **: Invalid UTF-8 passed to g_io_channel_write_chars().
dropbox_write() - G_IO_STATUS_ERROR

Im running Arch-Linux with Thunar 1.6.3 and the thunar-dropbox AUR package 0.2.0-1

Haddayn commented 9 years ago

I added a fix for that: https://github.com/Maato/thunar-dropbox/pull/6

DanielAW commented 9 years ago

Hi Huddayn,

thanks! A quick test shows that thunar stops crashing now in my case :smile: But now thunar shows no "Move to Dropbox" option for the file with the invalid encoding in the context menu. Is this intentional?

BTW: Thunar is now on version 1.6.4 on my system

Haddayn commented 9 years ago

Yes, it is intentional. It skips files with invalid encoding, because g_io_channel_write_chars expects valid UTF-8 and otherwise it's unable to communicate with dropbox.