search

Maato / volumeicon

Volume Icon aims to be a lightweight volume control that sits in your systray.
http://nullwise.com/volumeicon.html
GNU General Public License v3.0
183 stars 45 forks source link

Bug fixes - 100% CPU on disconnect, and Gtk panel icon detection #31

Closed stevenhoneyman closed 10 years ago

stevenhoneyman commented 10 years ago

Pass G_IO_ERR to asound_poll_cb, and exit gracefully if an error happens. Without this, it never passes the error and infinitely loops as fast as it can, causing 100% CPU utilization.

Signed-off-by: Steven Honeyman stevenhoneyman@users.noreply.github.com

nkoep commented 10 years ago

This pull request contains too many unrelated changes if you ask me. Please group related commits into sensible topic branches and open pull requests for them individually. 7232294 in particular adds a whole new (old) feature and should therefore have its own PR. I could alternatively cherry-pick the respective commits, but I'd prefer not to.

stevenhoneyman commented 10 years ago

OK, I'll apply the patches one at a time starting from a clean source and resubmit.

Thanks