search

Maato / volumeicon

Volume Icon aims to be a lightweight volume control that sits in your systray.
http://nullwise.com/volumeicon.html
GNU General Public License v3.0
183 stars 45 forks source link

Allow use of a decibel scale again #42

Closed jlindgren90 closed 9 years ago

jlindgren90 commented 10 years ago

I prefer this type of volume control, where a 10% adjustment on the scale always changes the volume by the same number of decibels. (Compare with alsamixer, where from 5% to 15% is a 30 dB change, while from 85% to 95% is only 3 dB.) Can the decibel scale be made an option again?

nkoep commented 10 years ago

While I think it would be fine to add this feature, I have a couple of comments for the pull request. First of all, what's up with targetting gtk2 again instead of gtk3? I doubt @Maato would agree with that decision. Secondly, decibel is a (pseudo-)unit for logarithmic scales. The two available options should therefore be "linear scale" and "logarithmic scale". And finally, if it's configurable whether a linear or logarithmic scale is used, I think the interface should reflect the choice by displaying percentage and/or decibel values in tooltips and OSD windows as well.

jlindgren90 commented 10 years ago

The GTK2 port wasn't supposed to be part of the pull request, sorry about that. The improvements you suggest sound good, but I probably won't be the one to implement them since I want to spend my time working on the next Audacious release.

nkoep commented 10 years ago

Fair enough. I'd actually like to hear @Maato's opinion on this first, but if he gives the go-ahead, I'd be willing to work on the feature.

Maato commented 10 years ago

This sounds like a nice addition if it is implemented in the way you described it. I do think that with the addition of yet another configuration option the preferences window should be reorganized a bit, as it does not (hasn't for a while) fit on my laptop's small screen.

jlindgren90 commented 9 years ago

Superseded by https://github.com/Maato/volumeicon/pull/46.