Would be nice to have volumeicon using GTK 3

Maato / volumeicon

Volume Icon aims to be a lightweight volume control that sits in your systray.

http://nullwise.com/volumeicon.html

GNU General Public License v3.0

183 stars 45 forks source link

Would be nice to have volumeicon using GTK 3 #7

Closed gpocentek closed 12 years ago

gpocentek commented 12 years ago

configure.ac: check for GTK 3
- volumeicon.c, bind.c: don't use deprecated objects and methods
- volumeicon.c: drop GTK 2 version checks

Maato commented 12 years ago

There seems to be a problem with your changes to bind.c, when I start volumeicon it segfaults immediately. I'm guessing you don't have any hotkeys enabled in the configuration so you didn't encounter this problem.

gpocentek commented 12 years ago

Indeed I don't have hotkeys enabled. But I can't enable them with 0.4.6 on debian (just discovered the problem). The checkbox can't be checked and I got this warning messages:

\ (volumeicon:6675): WARNING **: Binding 'XF86AudioRaiseVolume' failed! Failed to bind XF86AudioRaiseVolume

\ (volumeicon:6675): WARNING **: Binding 'XF86AudioLowerVolume' failed! Failed to bind XF86AudioLowerVolume

\ (volumeicon:6675): WARNING **: Binding 'XF86AudioMute' failed! Failed to bind XF86AudioMute

Maato commented 12 years ago

That probably means some other program has already bound them. Just try with some different keys (you can change the default ones by clicking on them), or try to find which program it is and unbind them there.

gpocentek commented 12 years ago

Ah right, I already had bindings set in GNOME.

I've not been able to reproduce the crash, but had to made a small adjustment to make key bindings settings work. Could you send a backtrace if the crash happens again?

I'm new to github, I'm not sure if I need to do a pull request again or if you have what you need to test.

Thanks.

Maato commented 12 years ago

That small adjustment has fixed the crash for me.

So I'll merge your changes.

Thanks