search

MaayanLab / drugmonizome-issues

0 stars 0 forks source link

Kinome Scan should be spelled KINOMEscan #21

Closed AviMaayan closed 3 years ago

AviMaayan commented 3 years ago

Also, the HMS LINCS logo should be replaced with this one: image

ekropiwnicki commented 3 years ago

The resource was renamed and the logo was replaced

jeevangelista commented 3 years ago

@ekropiwnicki why's the logo distorted? https://raw.githubusercontent.com/MaayanLab/Drugmonizome/master/drugmonizome-schemas/images/kinomescan.ico

ekropiwnicki commented 3 years ago

@jeevangelista the original photo's dimensions were such that the width of the image was 3x the height. If I used that as the native image then it would spill into the text section on the UI cards. To compensate I resized the height and width dimensions to be closer together which prevents this. Is there a better solution?

jeevangelista commented 3 years ago

hmm... this was the one we used for sigcom-lincs: https://maayanlab.cloud/sigcom-lincs/#/DSGCs/HMS_LINCS https://maayanlab.cloud/sigcom-lincs/static/images/lincs/hms-lincs.png

Should we use this instead? @AviMaayan

AviMaayan commented 3 years ago

It needs to say HMS LINCS KINOMEscan because KINOMEscan is a company so it will be confusing if you just have that logo with no text about HMS.

AviMaayan commented 3 years ago

I see the problem... It needs to be a square logo... Also the UNM logo needs to be replaced with a square logo...

AviMaayan commented 3 years ago

You can use this one for TCRD image

AviMaayan commented 3 years ago

This can be used for HMS image

jeevangelista commented 3 years ago

non-square logos (within reason) should look better now: https://maayanlab.cloud/drugmonizome/#/Resources/953a5d0e-fa1c-4270-b5bc-8b64b5778051

I just need to make the results section larger on the metadata search to fix the issues there

AviMaayan commented 3 years ago

Looks good!