search

MaayanLab / enrichr_issues

5 stars 3 forks source link

[BUG][DOC] Odds Ratio Formula in the docs correct? #78

Closed sreichl closed 8 months ago

sreichl commented 9 months ago

Describe the bug The odds ratio formula shown in the docs does not seem to be correct. Additionally, please explain the motivation for using Math.max().

Observed formula $oddsRatio = (1.0 * a * d) / Math.max(1.0 * b * c, 1)$

Expected formula Plus (+) 1 instead of times () 1 (<- which does not make a difference). $`oddsRatio = (1.0 + a d) / Math.max(1.0 + b * c, 1)`$

sreichl commented 8 months ago

Nevermind, I think the original formula is correct, but the multiplication with 1 is still confusing/unnecessary.