search

MaazAli / Meteor-HighCharts

HighCharts for Meteor, with an easy to use helper to get you started!
MIT License
53 stars 20 forks source link

Adding support for heatmaps #11

Closed mhourahine closed 9 years ago

mhourahine commented 9 years ago

Added support for HightChart Heatmaps. I also bumped the version number. Hope that works for you.

jhuenges commented 9 years ago

Looks good to me. Can you maybe add a short description in the readme? Or just mention that highmaps is also available

mhourahine commented 9 years ago

Ok did that. I also noticed the version of the heatmap.js file I added wasn't inline with the highcharts version so I updated everything to the latest v4.1.3.

jhuenges commented 9 years ago

:+1:

MaazAli commented 9 years ago

Will test it out once I get home, good work.

MaazAli commented 9 years ago

I'm wondering if this package should support all these different highchart addons. Considering the users of this package do not have a way to opt-out of importing the heatmaps addon for example. This would cause all of the additional javascript to be loaded when some users may not need it at all. Causing the initial .js payload to be even larger than it already is. What do you guys think?

jhuenges commented 9 years ago

We could create different packages. I already have a highstock package.

mhourahine commented 9 years ago

I'd be fine with that. Maaz, if you update your package to have the latest versions, I'll just create another package called highcharts-heatmaps that will depend on yours and add the heatmap module. Sound good?

On Tue, Mar 10, 2015 at 2:16 AM, jhuenges notifications@github.com wrote:

We could create different packages. I already have a highstock package.

— Reply to this email directly or view it on GitHub https://github.com/MaazAli/Meteor-HighCharts/pull/11#issuecomment-78001491 .

MaazAli commented 9 years ago

@mhourahine Sounds great. That seems like the best approach to be honest. I'll update the package to the latest.

MaazAli commented 9 years ago

@mhourahine here is the commit: https://github.com/MaazAli/Meteor-HighCharts/commit/9948139e995f5169d08ea212dd60a750aad54fba

mhourahine commented 9 years ago

Awesome thanks! Here is the new highcharts-heatmaps repo: https://github.com/mhourahine/meteor-highcharts-heatmaps

Mike

On Wed, Mar 11, 2015 at 11:36 PM, Maaz Ali notifications@github.com wrote:

@mhourahine https://github.com/mhourahine here is the commit: 9948139 https://github.com/MaazAli/Meteor-HighCharts/commit/9948139e995f5169d08ea212dd60a750aad54fba

— Reply to this email directly or view it on GitHub https://github.com/MaazAli/Meteor-HighCharts/pull/11#issuecomment-78418390 .

MaazAli commented 9 years ago

Looks good!