search

MaazAli / Meteor-HighCharts

HighCharts for Meteor, with an easy to use helper to get you started!
MIT License
53 stars 20 forks source link

Update highcharts to v4.1.10 #35

Closed jkhedani closed 8 years ago

jkhedani commented 8 years ago

Sorry, I've never submitted a pull request before. Installed my fork as a custom package in my current meteor project utilizing high charts and the features I needed are working. Not sure what highcharts-more does but can confirm the no data module is working. Thanks for maintaining this!

jhuenges commented 8 years ago

You did the right thing, except it is better to use the non-minfied versions. Meteor will minify every js file. If you could change this, it would be great :+1:

MaazAli commented 8 years ago

Yeah, no minification please!

jkhedani commented 8 years ago

Ah, that makes sense. Updated and pushed. Thanks for the guidance!

jhuenges commented 8 years ago

I ll test this later today and merge if everything works

jhuenges commented 8 years ago

Looks good to me. @MaazAli should I merge this, or will you do this and publish it to atmosphere?

MaazAli commented 8 years ago

@jhuenges you can merge :+1: