search

MaazAli / ember-cli-sortable

Ember CLI addon for RubaXa's sortable plugin
MIT License
18 stars 24 forks source link

Build failing on Ember 2.12 #14

Open laantorchaweb opened 7 years ago

laantorchaweb commented 7 years ago

Maybe related to having Ember moved away from bower_components, but it's throwing this error:

Error: Cannot find module '/bower_components/ember/ember-template-compiler'
at Class.module.exports.htmlbarsOptions (/node_modules/ember-cli-sortable/node_modules/ember-cli-htmlbars/ember-addon-main.js:70:25)
laantorchaweb commented 7 years ago

Hey, @MaazAli any ideas about how to solve this issue? If I make a PR can you merge and publish?

ghost commented 7 years ago

having same issue Ember version 2.14.1. Any fix for that?

ghost commented 7 years ago

@laantorchaweb did you find any solution plz share.

MaazAli commented 7 years ago

I'm no longer maintaining this addon, it is very likely that it no longer works!

SanthoshRaju91 commented 6 years ago

Hello,

Sorry to comment on this thread again, even though you meant that this is not longer maintained. But this addon is being used in one of our project's and by many of them as well.

So I took the privilege, in upgrading the addon to 2.12, fixing the eslint issues, and writing a small working example of the addon.

Also, I have updated the index.js file, to include _findHost hook. So this support ember-engine's application as well.

I have raised a PR. Could you please validate them and merge it.

Warm Regards.