MacDownApp / macdown

Open source Markdown editor for macOS.
https://macdown.uranusjr.com/
9.45k stars 1.09k forks source link

Bug: Cmd+Shift+O maps to two different menu commands #1250

Open mjbaldwin opened 3 years ago

mjbaldwin commented 3 years ago

Just wanted to inform you that the keyboard shortcut Cmd+Shift+O maps to both of the menu commands:

So while I'm trying to use Cmd+Shift+O and Cmd+Shift+H to toggle showing and hiding the preview pane, it keeps inserting an ordered list instead. :(

I have no preference for which one should keep the shortcut... but when I'm editing a long complex Markdown document, the preview pane is constantly flashing with every keystroke which makes it unusable, so I need to hide it, but then want to quickly show it at times so keeping some keyboard shortcut is essential.

Thanks so much -- wonderful app!

Neecolaa commented 3 years ago

Cmd+Shift+H toggles both showing and hiding the preview pane. You shouldn't have to use Cmd+Shift+O to show the preview pane.

mjbaldwin commented 3 years ago

Thanks for the suggestion, but I'm trying Cmd+Shift+H right now and it's not showing the preview pane.

I'd wonder if I had something else interfering with the keyboard shortcut (e.g. I'd reassigned it elsewhere) but I don't think that could be the case because it works to hide the pane.

I'm using version 0.7.3 (says it's up-to-date) on Big Sur which is also up-to-date.

I'm happy to help debug this if needed, attach screenshots to show the menu state, etc.

Neecolaa commented 3 years ago

Interesting.. I've also got 0.7.3, but I'm using Catalina (10.15.7) When the preview pane is hidden, what does the View drop-down say Cmd+Shift+H does?

Screen Shot 2021-06-25 at 10 04 45 PM
mjbaldwin commented 3 years ago

When the preview pane is hidden it just shows continues to show "Hide Preview Pane":

image

I've tried playing around with it some more, and discovered that as long as the entire markdown document is shorter than the viewport (entirely visible) then the menu command does change to "Restore Preview Pane" and works normally.

But as soon as I add more text so that it scrolls vertically, when I hide the preview pane the menu continues to say "Hide Preview Pane" and restore doesn't work.

grievejia commented 2 years ago

I had the same issue with @mjbaldwin. This issue makes it a bit painful when writing long docs.