Amp client warning for pipeline method

MacFJA / php-redisearch

PHP Client for RediSearch

MIT License

67 stars 9 forks source link

Amp client warning for pipeline method #19

Open kelunik opened 2 years ago

kelunik commented 2 years ago

Hey @MacFJA,

It's great to see support for amphp/redis built-in! Could you tell me what the notice in https://github.com/MacFJA/php-redisearch/blob/6d3a675c54fc5c9f675c50d860f2b3d50eab1972/src/Redis/Client/AmpRedisClient.php#L75 is supposed to mean?

MacFJA commented 2 years ago

It's just that, AFAIK, there is not pipeline in Amp\Redis, so each command need to be send one by one, and are also executed one by one.

Where with a Redis pipeline:

all commands are sent to the server in one go
the server execute all commands
the server send one message containing all commands response.

With pipeline only one network request is made instead of one per command.

kelunik commented 2 years ago

While amphp/redis uses separate write calls, pipelining is more about avoiding the RTT cost and it's totally supported by amphp/redis. The client won't wait for a server response before sending the next command. It uses pipelining by default.