search

MacGapProject / MacGap1

Desktop WebKit wrapper for HTML/CSS/JS applications.
Other
3.55k stars 208 forks source link

Several new features and a fix #10

Closed liamks closed 12 years ago

liamks commented 12 years ago

New Features:

  1. create a new window
  2. resize window
  3. move window
  4. when user a clicks on a link that opens a new window, a new window is created.

Fix:

  1. When a user presses command-c and then clicks on the dock icon the window reappears.
hrnn commented 12 years ago

This is a really great contribution i hope to be merged soon

judofyr commented 12 years ago

What about a callback for when a window is closed?

judofyr commented 12 years ago

Oh, or is onbeforeunload called then?

liamks commented 12 years ago

@judofyr do the regular javascript callbacks not work?

winterlightning commented 12 years ago

Why isn't this being merged? Seem to fix a lot of crucial stuff

liamks commented 12 years ago

I suspect @maccman is a busy guy. He has several large open source projects and likely a full-time job. I'm sure he'll merge this, or a version of it, in the next week or so (hopefully!!).

maccman commented 12 years ago

Yes, I do plan to. Keep pinging me :) - sorry for the delay.

liamks commented 12 years ago

Ping! Once this pull-request, and the other, is accepted that will remove 3 issues and make tackling some of the others much easier!

maccman commented 12 years ago

@liamks just been playing around with it - looks great. I think once support for loading in remote windows is there (only supports local windows), I'll definitely merge it.

liamks commented 12 years ago

Something like: macgap.window.load('window1','http://asdf.com') ?

maccman commented 12 years ago

Done it :)

liamks commented 12 years ago

Good work!

winterlightning commented 12 years ago

Great work both of you!