search

MacGapProject / MacGap1

Desktop WebKit wrapper for HTML/CSS/JS applications.
Other
3.55k stars 208 forks source link

WebPreferences can be altered by changing values within WebPreferences.plist #23

Closed liamks closed 12 years ago

liamks commented 12 years ago

Developers can now enable WebGL & Developer tools via the WebPreferences.plist.

maccman commented 12 years ago

It's cool, but just being devil's advocate for the second - would anybody want these turned off?

maccman commented 12 years ago

I.e. what's the point of being able to configure something that everybody wants enabled?

liamks commented 12 years ago

Personally I think they should all just be enabled. The plist might provide utility to someone debugging an app?

liamks commented 12 years ago

I think when you give developers more options they tend to create things which one could hardly conceive of initially. I think providing options is positive. On the other hand, opinionated software tends to reduce the options in favour of defaults... I suppose the question is, is MacGap opinionated?

navitronic commented 12 years ago

I'd want developer tools turned off if I was distributing an app to others that I didn't want them casually poking around in.

I obviously realise more clued in user's could turn it on.

maccman commented 12 years ago

We don't enable any dev features atm, as you can easily test stuff in the browser.

liamks commented 12 years ago

@maccman I've found developer tools to be very useful. I can't test MacGap only features in a browser. When adding new features I found the developer tools indispensable. As a result I added them to WebPreferences.plist (disabled by default though).

winterlightning commented 12 years ago

Developer tools are enormously helpful. The browser is a hugely different env.

For example, you can't test stuff that comes with the macgap api such as growl.

As to users who can poke around, there is no source code protection for macgap anyways since anyone can just look at the code in the www folder.

liamks commented 12 years ago

Ok, what if I only have developer tools and WebGL on the WebPreferences, since the other options will most likely be always enabled?

maccman commented 12 years ago

I was thinking we could always enable webgl, and enable the dev tools with an env variable. How about that?

liamks commented 12 years ago

Good compromise. Should I toss them in Constants.h, or create a new header file?

maccman commented 12 years ago

Fixed in #aed75f91bf9ee717a2372334dd48286453c46329

You can switch it on by running:

settings write com.MacGap developer 1