MacHu-GWU / uszipcode-project

USA zipcode programmable database, includes up-to-date census and geometry information.

MIT License

231 stars 49 forks source link

fixing breakage from SqlAlchemy 1.4 #49

Closed aaronsmith1234 closed 3 years ago

aaronsmith1234 commented 3 years ago

Seems like it fixes it, all tests passed. Also a bit scared about the code embedded in the Chinese I had to change, but tests pass....

codecov-io commented 3 years ago

Codecov Report

Merging #49 (73df027) into master (2b88ba5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files           4        4           
  Lines         386      386           
=======================================
  Hits          383      383           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53f37b9...73df027. Read the comment docs.

aaronsmith1234 commented 3 years ago

@evladik doesn't look like this ever got merged; anything else you need me to do?

jsbain commented 3 years ago

Someone probably ought to remove the except/pass that hides the reason for the failure!

aaronsmith1234 commented 3 years ago

@jsbain yeah, I thought about that, but wasn't sure why it had been put in, so took the minimal route of at least getting the code working again with SA 1.4, and not trying to overhaul too much. @evladik @MacHu-GWU any reason not to merge?

MacHu-GWU commented 3 years ago

@aaronsmith1234 Awesome, sorry I didn't realize it is fixed yet. The reason why I am not very active on updating this version is because I am crawling the up-to-date dataset based on 2020 Census and IRS data. Plan to issue a 2.x versioin in two month. Thank you for your contribution!

aaronsmith1234 commented 3 years ago

@MacHu-GWU can you push a new version to pypi? If not, everyone who downloads the current version and the newest sql alchemy will run into issues (like our current ci build is).

MacHu-GWU commented 3 years ago

@aaronsmith1234 Yes, will do today.

aaronsmith1234 commented 3 years ago

Hey @MacHu-GWU , just checking in, can you push a version with the fix above to pypi? Causing our CI builds to fail. Thanks!! Awesome package, appreciate all the good work!

MacHu-GWU commented 3 years ago

@aaronsmith1234 Sorry for that will release one from master now. BTW, you could fork one from this repo and use pip to install from your own github repo. This is how I usually solve it when my project depends on an open-source project that missing some feature.

MacHu-GWU commented 3 years ago

@aaronsmith1234 please check pip install uszipcode==0.2.5