search

MacPass / KeePassKit

KeePass Database loading, storing and manipulation framework
Other
125 stars 40 forks source link

fix writing randomStreamId #15

Closed skyline75489 closed 8 years ago

skyline75489 commented 8 years ago

This crashes the test. However even with this fix, there are still some test cases are failing. Is this expected?

skyline75489 commented 8 years ago

I'm on Xcode 8 and macOS 10.12

mstarke commented 8 years ago

Thanks, already onto this. There are still problems with saving/loading since I am in the middle of KDBX4.0 support. Seems I have missed a few spots.

mstarke commented 8 years ago

Just a note. KeePassKit master is not always stable so if you really want to use this, I should incorporate a better development style.

skyline75489 commented 8 years ago

Yeah...I'd expect, like most of people, that the master branch should be working. Anyway, I'm still glad to know that this is in progress. I'd love to help on this project within my power.

Thanks for the great work (both MacPass and KeePassKit), by the way. Cheers. 🍻

mstarke commented 8 years ago

Sorry for the inconvenience, but I've gotten used to being the sole user of this so it's not always plug'n'play. Thanks for the kind words!

mstarke commented 8 years ago

Tests now work in master. There were still some bugs in storing VariantDictionaries and in saving the KDBX4 format. I suspect there are more edge cases. Also, the use of a encapsulated Version information was needed.

There are still many aspects of the framework, that are not fully covered via tests to ensure well defined behaviour. Some sanity checks on writing are also needed.

If you feel up to it, I would love some support. Maybe we can coordinate it via the "projects" feature recently introduced to GitHub?

Aspect that need more testing are the modification/access/move dates since the synchronisation feature highly depends on those working properly. Synchronisation is actually the biggest part still missing.

skyline75489 commented 8 years ago

I'd be glad to offer my help.

I've been a long time user of KeePass. However, I'm not really familiar with the underlying implementation. It may take me some time to fully understand the code base and catch up with the development pace.

mstarke commented 8 years ago

Take your time. If you find anything awkward feel free to offer suggestions. The architecture might benefit from another set of eyes. We can chat via irc on #macpass at freenode if you have questions.