search

MacPass / MacPass

A native macOS KeePass client
https://macpassapp.org
Other
6.74k stars 466 forks source link

Crash on attempt to add entry after search w/ zero results #444

Open jeffmcneill opened 8 years ago

jeffmcneill commented 8 years ago

Behavior:

mstarke commented 8 years ago

I cannot reproduce this error. Can you attach a detailed error log?

mstarke commented 8 years ago

Any news own this issue?

jeffmcneill commented 8 years ago

Exception Name: NSRangeException Description: *\ -[NSIndexSet initWithIndexesInRange:]: Range {9223372036854775807, 1} exceeds maximum index value of NSNotFound - 1 User Info: (null)

0 CoreFoundation 0x00007fff9230a03c exceptionPreprocess + 172 1 libobjc.A.dylib 0x00007fff9060576e objc_exception_throw + 43 2 CoreFoundation 0x00007fff92309eed +[NSException raise:format:] + 205 3 Foundation 0x00007fff909b40cb -[NSIndexSet initWithIndexesInRange:] + 138 4 Foundation 0x00007fff909d229a +[NSIndexSet indexSetWithIndex:] + 43 5 MacPass 0x0000000101792f9d -[MPEntryViewController _didAddItem:] + 421 6 CoreFoundation 0x00007fff922c645c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER + 12 7 CoreFoundation 0x00007fff921b6634 _CFXNotificationPost + 3140 8 Foundation 0x00007fff9099aaa1 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66 9 MacPass 0x00000001017a8af8 -[MPDocument createEntry:] + 855 10 MacPass 0x000000010178b785 -[MPDocumentWindowController createEntry:] + 126 11 libsystem_trace.dylib 0x00007fff93411cd7 _os_activity_initiate + 75 12 AppKit 0x00007fff86966eb1 -[NSApplication sendAction:to:from:] + 452 13 AppKit 0x00007fff8697c946 -[NSControl sendAction:to:] + 86 14 AppKit 0x00007fff8697c862 __26-[NSCell _sendActionFrom:]_block_invoke + 131 15 libsystem_trace.dylib 0x00007fff93411cd7 _os_activity_initiate + 75 16 AppKit 0x00007fff8697c7bf -[NSCell _sendActionFrom:] + 144 17 AppKit 0x00007fff8697c715 -[NSSegmentedCell _sendActionFrom:] + 105 18 libsystem_trace.dylib 0x00007fff93411cd7 _os_activity_initiate + 75 19 AppKit 0x00007fff8697acb3 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 2821 20 AppKit 0x00007fff86979de1 -[NSSegmentedCell trackMouse:inRect:ofView:untilMouseUp:] + 1506 21 AppKit 0x00007fff86979366 -[NSControl mouseDown:] + 714 22 AppKit 0x00007fff86ee32dc -[NSWindow _reallySendEvent:isDelayedEvent:] + 14125 23 AppKit 0x00007fff86872c86 -[NSWindow sendEvent:] + 470 24 AppKit 0x00007fff8686f212 -[NSApplication sendEvent:] + 2504 25 AppKit 0x00007fff86798b68 -[NSApplication run] + 711 26 AppKit 0x00007fff86715244 NSApplicationMain + 1832 27 libdyld.dylib 0x00007fff8bc8d5c9 start + 1 28 ??? 0x0000000000000001 0x0 + 1

jeffmcneill commented 8 years ago

Note: the steps need another first step:

mstarke commented 8 years ago

I am still unable to reproduce this bug. What version of MacPass are you using? I just tested you steps with 0.6 and 0.6.2 and the current master and it works on all those versions. By + Add do you mean the button at the bottom? This was removed in 0.6.2 so you must be using 0.6.1 or older.

jeffmcneill commented 8 years ago

0.6.2

Steps:

  1. Open MacPass

screen shot 2016-06-04 at 14 40 01

  1. Click on Root folder (you may need entries in root, I have)

screen shot 2016-06-04 at 14 40 29

  1. Click in the Search bar, type in search string, and type Enter, see search results

screen shot 2016-06-04 at 14 40 52

  1. Click the + Add Entry button in the upper left hand corner of the screen

screen shot 2016-06-04 at 14 41 04

Note, I am on Yosemite 10.10.5

mstarke commented 8 years ago

I'll run some more tests under 10.10. I was trying to get the crash in 10.11 so this might be the ticket! Thanks for your efforts!