search

MacPass / MacPass

A native macOS KeePass client
https://macpassapp.org
Other
6.74k stars 464 forks source link

Edit undo/redo does not record history while editing notes #724

Open roblav96 opened 6 years ago

roblav96 commented 6 years ago

I'm not sure if this was intentional by design, but whenever I type into the notes field for an entry and use the edit undo command ⌘Z the entire note gets deleted. I don't know what Apple's equivalent is to an HTML Textarea (what I'm typing these words into) but I feel like the current implementation is just a really long multi-line Text Field.

Also, is there an option that would leave the password field blank when creating a new entry?

Let me know what you think of these =]

P.S. @mstarke This is one hell of an awesome project! I've recently joined the cryptocurrency bandwagon and MacPass is an absolute requirement for storing all my credentials to the ~20 exchanges I signed up for, but have yet to put a penny into any of them... I'm a chicken :D Thanks friend!

mstarke commented 6 years ago

This seems to be an issue with the text field not having a separate undo/redo history. I think I might have broken this accidental by disabling undo/redo on the input. But - if you finish editing a note and move the focus to something else and then undo, the whole change will get reverted. If you type into the notes field and then undo, only the currently typed changes will get undone.

Could you try to edit a different field (e.g. the username) and use undo to see if the behaviour on those fields is like you expect it to be?

And thanks for the praise but MacPass is merely a port of an already established application (KeePass) so I only tried to make a good macOS version of this app.

roblav96 commented 6 years ago

Well you sir have succeeded at making a great OSX version!

The undo/redo is hard to explain. I'm having difficulty finding a pattern that can be replicated.

I came across another keyboard shortcut command bug. When the toolbar is toggled to hidden ⌥⌘T and try to copy the username or password of the selected entry ⌥⌘C it doesn't do anything. When the toolbar is toggled to visible, it works as expected. I honestly wouldn't loose any sleep over it, just thought I'd let ya know =]

roblav96 commented 6 years ago

Also drag and drop multiple selected entry items into a group folder doesn't work :X

mstarke commented 6 years ago

Thanks for the other bug - this seems to be related to the menu not being used in the responder chain. About multiple entries dragging this is a known limitation. Please try to file new bugs for new issues :).

roblav96 commented 6 years ago

Ah yes of course! I'll take care of that for you right now. My apologies =]