search

MacSummer / make-it-so

Automatically exported from code.google.com/p/make-it-so
1 stars 0 forks source link

Conversion fail, if solution contains unloaded projects #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Unload at least one of your projects in solution (Properties -> Unload 
project)
2. Save solution
3. Run make-it-so

What is the expected output? What do you see instead?
Conversion is expected, but whole conversion of solution is aborted due to the 
exception.

What version of the product are you using? On what operating system?
1.2, Windows 7, VS2010

Please provide any additional information below.
I provided a patch, which checks some basic properties of the project and if 
the project appears to be unloaded (unfortunately there's no direct property), 
the current project is simply skipped from conversion and a warning is sent to 
the command line.

Original issue reported on code.google.com by simon.jk...@gmail.com on 14 Oct 2013 at 10:10

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Simon,

I do use solutions with unloaded projects but I don't have any problem with 
them, as long as they aren't a dependency for enabled projects.

I guess adding a warning instead of blocking the conversion would be better 
indeed. Before I look at it, could you confirm it only happens if you have 
dependencies to the unloaded project? (Must be loaded to have it appear in the 
dependencies list)

Original comment by florian.sainjeon on 20 Nov 2013 at 10:16

GoogleCodeExporter commented 9 years ago 
Hi Florian,

at least with VS2010 solutions, the error occurs also with projects which 
aren't a dependency for other projects.
But I had to close VS after unloading a project to reproduce the error.

Original comment by simon.jk...@gmail.com on 21 Nov 2013 at 8:46

GoogleCodeExporter commented 9 years ago 
Okay, that's strange :/
Will add the warning ASAP then. It will add more flexibility to the app.

Anyway, could you attach me your solution (or a dummy one which reproduces the 
same architecture) to let me compare with mine? 
Checked today and my solution is well parsed as long as the unloaded project(s) 
aren't used as dependencies, dunno where it comes from.

Original comment by florian.sainjeon on 21 Nov 2013 at 1:48

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Changes made, could you check with the newly generated exe if it's working 
correctly before I make it commit the changes?

Original comment by florian.sainjeon on 25 Nov 2013 at 2:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Florian,

change of the exe was not sufficient, maybe the DLLs are also needed?

Original comment by simon.jk...@gmail.com on 26 Nov 2013 at 7:51

GoogleCodeExporter commented 9 years ago 
Woopsie! It was the DLLs to replace of course, not the exe. 

Here you go.

Original comment by florian.sainjeon on 26 Nov 2013 at 8:26

Attachments:

GoogleCodeExporter commented 9 years ago 
Works! :)

Didn't test the VS2008 version as I currently don't have a 2008 solution 
available.

Original comment by simon.jk...@gmail.com on 26 Nov 2013 at 9:39

GoogleCodeExporter commented 9 years ago 
Great! 

Just tested it on MakeItSo's solution since it's on 2008, working fine.
Thanks :)

Original comment by florian.sainjeon on 26 Nov 2013 at 9:47