MacWarrior / clipbucket-v5

Open source video hosting with PHP
Other
69 stars 45 forks source link

Profile name missing next to "by" under video on channel page #382

Closed SaturnTeamDev closed 1 month ago

SaturnTeamDev commented 1 month ago

When users see a video on the Videos page, it says, "by username" under the video. But if they load that user's channel page from the Channels page, the same video just says, "by" under the video. Their name is missing. I'm not sure why.

SaturnTeamDev commented 1 month ago

Update: This problem is also affecting videos in the Related sidebar and on the Homepage. Usernames have vanished. I was supposed to launch my site today but this has stopped my launch. These are the two files containing the author span class with "by" attached: upload/styles/cb_28/layout/blocks/video.html upload/styles/cb_28/layout/blocks/videos/video.html

I have been looking at the way the author name is initialized in these pages. There are at least three different ways. Some page types use this: {display_clean($video.username)} Other page types use this variation: {display_clean($video.user_username)}

I will play around more with the code tomorrow to see if I can fix this.

MacWarrior commented 1 month ago

Hello @SaturnTeamDev,

I'm not reproducing this king of issue on my side ; which version / revision of ClipBucketV5 are you using ? Latest is 5.5.1 - 55

Please also provide a few screenshots

Thanks by advance, Best regards, MacWarrior.

SaturnTeamDev commented 1 month ago

Here are the relevant screenshots including the revision screen. This site was created using the automatic installation script. IssuePic1 IssuePic2 IssuePic3

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

Thanks for reply, I was looking at the wrong spot... I'll fix it asap !

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

Issue was fixed on latest revision

Best regards, MacWarrior.

SaturnTeamDev commented 1 month ago

Ouch! This is so frustrating. I was fixing the code myself. Then, I upgraded to your new revision. Now, the username is not showing up on the Videos page and the Collections page! I'm looking through the code to try to figure out how to fix it. I was hopeful I was going to be able to launch my site today. You should run through all the pages to check for these problems. Thank you. I'm going to restart some processes on my server and clear the cache to see if that helps.

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

It's all about old vs new systems in place... I'll fix it asap...

EDIT : Thanks for reply !

Best regards, MacWarrior.

SaturnTeamDev commented 1 month ago

Okay. Now, the problem I am having is that the nine preloaded videos on the Channel page are missing the username. When I click to load more, those do have the username next to "by". I am checking the code, but have not found the solution yet, because I don't know what the $display_type is for that section. Here is a screenshot: ChannelsIssue

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

I've pushed lots of fixes I've been working on for the last few weeks I also included a fix for video uploader's username

Best regards, MacWarrior.

SaturnTeamDev commented 1 month ago

Hi @SaturnTeamDev,

I've pushed lots of fixes I've been working on for the last few weeks I also included a fix for video uploader's username

Best regards, MacWarrior.

Okay, I appreciate it. Could you at least tell me what the $display_type is for that preloaded (top nine videos) user channel section? Right now, I am just editing each possible type section and reloading the site to figure out where it is in the code. Thanks.

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

In view_channel.html :

{include file="$style_dir/blocks/videos/video.html" display_type='homeVideos'}
SaturnTeamDev commented 1 month ago

Okay. I just used my browser's dev tools to identify the display type. It shows "div id="user-videos". That's weird, I don't know why we came up with two different identifiers.

Update: I got the username to show up in those top videos on the user channel page by making sure it said $video.username in the homeVideos section of code. BUT now, the usernames have disappeared from the videos on the Collections page!

SaturnTeamDev commented 1 month ago

I can see now that view_collection.html is saying that Collections and each user channel page both use homeVideos. That seems to be creating some kind of conflict and resulting in only one being able to show the username under the video. I am going to try to copy the code block in the video page html to create a separate display type for Collections.

SaturnTeamDev commented 1 month ago

Revision 57 Update: I just upgraded the site. Now, I have two problems. The issue I was having on the user channel page is now reversed. The nine preloaded videos show the username. But when I click the "Load More" button, those extra videos do not show the username. There is also a new problem. The avatar pictures don't show on the main Channels page. I checked the code using dev tools in the browser and it shows the avatars on the Channels page are trying to be loaded as Gravatars and resulting in no Gravatar found. If I load each individual channel page, the avatars show up. I turned off Gravatars. But the avatars still don't load. I am stopping work soon for today. I hope you have better luck with this.

MacWarrior commented 1 month ago

Hi @SaturnTeamDev,

Thanks for your returns ; it's always very valuable to get this corrected, so thanks again for reporting them.

1) User's avatar has been fixed in latest commit 2) Channel > Videos tab > Load more has also been fixed in latest commit

Best regards, MacWarrior.

SaturnTeamDev commented 1 month ago

@MacWarrior,

I have upgraded to Revision 60 and can confirm that this issue is now completely fixed. Also, the avatars are now working on the Channels page. Thank you for your hard work!