search

Macacoazul01 / month_picker_dialog

Internationalized dialog for picking a single month from an infinite list of years.
https://pub.dev/packages/month_picker_dialog
MIT License
70 stars 97 forks source link

add MaterialLocalizations to button_bar.dart #72

Closed just1982 closed 1 year ago

just1982 commented 1 year ago

labels in button_bar.dart is hardcoded to OK and CANCEL

Could it use MaterialLocalizations cancelButtonLabel and okButtonLabel instead of hardcoded values?

Macacoazul01 commented 1 year ago

Can you fix it in a PR? If not, later I'll check

just1982 commented 1 year ago

Still very new to flutter, so don't know if im the right person for it.

Macacoazul01 commented 1 year ago

You can try and i review

Macacoazul01 commented 1 year ago

saw the code, gonna check it tomorrow with more time.

Did you tried to execute it in a cupertino app too instead of a material?

I'm not sure if it'll work

just1982 commented 1 year ago

I have not, not familiar with cupertino app. it does seem to require this to work in the beginning of the app. localizationsDelegates: const [ GlobalMaterialLocalizations.delegate, GlobalWidgetsLocalizations.delegate, GlobalCupertinoLocalizations.delegate, ],

I don't know if that makes it a breaking change!

Macacoazul01 commented 1 year ago

Tested with cupertinoApp instead of material and everything still works.

I'm not sure if changing this in pubspec will break anyone's app

flutter:
  uses-material-design: true

If so, they will raise an issue