search

Macaulay2 / M2

The primary source code repository for Macaulay2, a system for computing in commutative algebra, algebraic geometry and related fields.
https://macaulay2.com
343 stars 230 forks source link

upgrade normaliz #1239

Closed DanGrayson closed 3 years ago

DanGrayson commented 4 years ago

... to version 3.8.5

DanGrayson commented 4 years ago

@mahrud -- how are we going to keep the two build systems in sync on package versions?

mahrud commented 4 years ago

I presume you mean libraries and programs? Should that be a requirement? e.g. currently the CMake build builds normaliz 3.8.4 (vs. autotools build at 3.7.2). I'll push a commit to bump it to 3.8.5 on that end.

My suggestion is that the autotools build could take advantage of the CMake build's make build-libraries target, since CMake makes looking for required libraries, building them, and imposing dependencies much easier. Other targets like make build-normaliz-test can also be used for make check

On Fri, Jun 5, 2020 at 7:08 AM Daniel R. Grayson notifications@github.com wrote:

@mahrud https://github.com/mahrud -- how are we going to keep the two build systems in sync on package versions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Macaulay2/M2/issues/1239#issuecomment-639442322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYAPRW22LEJHSWHNYQUZ3LRVDN37ANCNFSM4NTP22NQ .

DanGrayson commented 4 years ago

It would be a good idea to keep the versions in sync, for then examples and tests that work under one build system will be more likely to work under the other.

mahrud commented 3 years ago

Closing in favor of #1517.